fix: fix the fix to #884 to fix #1025 #1030
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #885 was incorrect, because it caused tokens straddling a buffer boundary to be split in half, leading to #1025. This fixes #1025 (and also #885)
The code is somewhat fragile, particularly the EOF handling. It would make a lot more sense just to read the entire stream into memory and treat EOF as a valid end of token...
How Has This Been Tested?
A new unit test with the specific cmap stream mentioned in #1025
Checklist