Interpret font Descent as a negative number even if specified as positive #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PDF RM specifies that Descent should be negative. Fonts that claim to have a positive Descent (not that it would make sense) always seem to be wrong about this claim.
jbarlow83
force-pushed
the
negative-descent
branch
from
0425475
to
2ede124
Compare
jbarlow83
changed the title
pietermarsman
approved these changes
Aug 4, 2019
There was a problem hiding this comment.
@jbarlow83, it has been a while since you've posted this PR, do you have time to some super small cosmetic changes?
I think it is a neat improvement.
And indeed, the pdf reference manual is clear that it should be below zero:
(Required, except for Type 3 fonts) The maximum depth below the baseline reached by glyphs in this font. The value is a negative number.
| # PScript5.dll seems to produce Descent with a positive number, but | ||
| # text analysis will be wrong if this is taken as correct. So force | ||
| # descent to negative. | ||
| if self.descent > 0: |
There was a problem hiding this comment.
Could you group all the code for self.descent? 11 lines above the numeric value is parsed and the additional logic is here.
|
@jbarlow83, do you have time for some tiny changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PDF RM specifies that Descent should be negative. Fonts that claim
to have a positive Descent (not that it would make sense) always seem
to be wrong about this claim.