use conditional requirements to ensure "chardet" is always required on Python 3 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t on Python 3 (fixes #213) Previously "chardet" was added only added when setup.py was run with Python 3. However wheels contain a static list of requirements and a wheel-based install will never execute setup.py at installation time. pdfminer.six uses universal wheels for Python 2 and Python 3 so the requirements will always be wrong on one version (see #213). The solution is to use conditional requirements as specified in PEP 496 which are evaluated at installation time.
|
Could anybody take a look at this, please? |
|
Has this been tested? |
|
I can confirm that it works as expected on Python 3.7 with pip 19.1.1, setuptools 41.0.1 and wheel 0.33.4. |
|
Let's merge this. The syntax checks out: https://www.python.org/dev/peps/pep-0496/#examples |
pietermarsman
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously "chardet" was added only added when setup.py was run with Python 3. However wheels contain a static list of requirements and a wheel-based install will never execute setup.py at installation time.
pdfminer.six uses universal wheels for Python 2 and Python 3 so the requirements will always be wrong on one version (see #213).
The solution is to use conditional requirements as specified in PEP 496 which are evaluated at installation time.