Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertionerror objid 0 #318

Merged
merged 5 commits into from
Oct 25, 2019
Merged

Fix assertionerror objid 0 #318

merged 5 commits into from
Oct 25, 2019

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Oct 25, 2019 •
edited
Loading

Description

Fixes #94

Removing assertion error because if objid == 0 it is just a special case of a missing object (objid should be positive).

How Has This Been Tested?

Tested with the invalid.pdf from #94.

Also added explicit test for getting objid 0.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the README.md and other documentation, or I am sure that this is not necessary
  • I have added a consice human-readable description of the change to CHANGELOG.md
  • I have added docstrings to newly created methods and classes

@pietermarsman pietermarsman merged commit a238a19 into pdfminer:develop Oct 25, 2019
@pietermarsman pietermarsman deleted the fix-assertionerror-objid-0 branch October 25, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when dump all
1 participant
@pietermarsman