Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove webapp and other application references: django, cgi, and spec. #320

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Oct 26, 2019

Description

Removes webapps and other helpfull files for applications using pdfminer.six. These files should be maintained as part of the application itself, not in pdfminer.six.

Fixes #314
Fixes #105

How Has This Been Tested?

The tests all pass, but I did not verify if anyone is actually using this. I sincerely hope that nobody is dependent on these files to run there application. But if so, these files can be copied easily from github and placed in a proper location.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the README.md and other documentation, or I am sure that this is not necessary
  • I have added a consice human-readable description of the change to CHANGELOG.md
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial version

@pietermarsman pietermarsman merged commit d88d602 into pdfminer:develop Oct 26, 2019
@CounterPly
Copy link

@pietermarsman

May I ask why these files were removed? Having these as a template to work from would have saved many hours.

Thank you for all the work you've put into this project.

@pietermarsman
Copy link
Member Author

Hi @CounterPly,

Because in my opinion good software is focused on solving one thing well. E.g. like the unix philosophy. Or the single-responsibility principle. Pdfminer.six is for extracting text and other content from PDF files. And not for setting up a webserver. There are other tools use can use for that.

Let me know if you have any specific questions on how to integrate pdfminer.six in a webserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove non-python files in tools directory PDFminer incompatible with django
2 participants