Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in computing character bounding box #348

Merged
merged 6 commits into from
Jan 16, 2020
Merged

Fix bug in computing character bounding box #348

merged 6 commits into from
Jan 16, 2020

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Dec 30, 2019 •
edited
Loading

Description

The /FontBBox property of the font was used, but this is not specified in the PDF Reference (see Section 5.3).

Fixes #48
Partially fixes #72

How Has This Been Tested?

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the README.md and other documentation, or I am sure that this is not necessary
  • I have added a consice human-readable description of the change to CHANGELOG.md
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial version
  • Test with other pdf's

@pietermarsman pietermarsman mentioned this pull request Dec 30, 2019
Closed
@pietermarsman
Remove scaling font height/width with size of font bounding box
5966b6f
@pietermarsman
Refactor LTChar bounding box computation
9b57703
@pietermarsman
Change expected outcome of `python tools/pdf2txt.py samples/simple3.p…
d654c14 
…df`, because it looks like an improvement. However, when I view `samples/simple3.pdf` I don't see any text at all. The change in expected outcome is explained by the fact that the bounding boxes of characters can be different, depending on the `/FontBBox` parameter of the font.
@pietermarsman
Add test for font sizes, and for this a high-level function that retu…
771b9d5 
…rns an iterator of LTPage objects
This was referenced Jan 9, 2020
Closed
Closed
@pombredanne
Copy link
Contributor

LGTM

@pietermarsman pietermarsman merged commit fff3ac2 into develop Jan 16, 2020
@pietermarsman pietermarsman deleted the fix-font-height branch January 21, 2020 20:08
@pietermarsman pietermarsman mentioned this pull request Mar 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF to HTML conversion issues Incorrectly Determining Height of Characters
2 participants
@pietermarsman @pombredanne