Fix font name by removing subset tag #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Font names from embedded fonts may have differently named subsets. For example, the font
Georgiamay have the subsetABCDEF+Georgia. The six letters before the plus sign is called a tag and can be used to identify different subsets of the same font.When converting to HTML the browser does not recogize the font if the tag is also included in the
font-familyname. This PR removes this font subset tag prefix.Fixes #349
Fixes #72
How Has This Been Tested?
With the pdf from #349.
Checklist
I have added tests that prove my fix is effective or that my feature works