Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove latin2ascii.py because it converts the latin-interpreted bytes of a file to ascii, but this has not much to do with PDF's. #360

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Jan 14, 2020

Description

An issue was raised in #356 about latin2ascii.py. I've never actually noticed this file but now there is a bug in it...

The latin2ascii.py file is a command line utility tool that can be use to convert the latin-interpreted bytes of a file to an ascii-encoded file. It does not use any of the functionality from pdfminer.six. I think we should remove this from our API because it is not part of the goal of pdfminer: extract text from pdf files.

Closes #356

How Has This Been Tested?

Nope

Checklist

  • I have updated the README.md and other documentation, or I am sure that this is not necessary
  • I have added a consice human-readable description of the change to CHANGELOG.md

@pombredanne
Copy link
Contributor

LGTM

@pietermarsman pietermarsman merged commit 52da65d into develop Jan 16, 2020
@pietermarsman pietermarsman deleted the fix-356-remove-latin2ascii branch January 21, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uncaught decoder failure
2 participants