Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove samples/ directory from source distribution to prevent downloading all pdf's when installing pdfminer.six #364

Merged
merged 4 commits into from
Jan 24, 2020
Merged

Remove samples/ directory from source distribution to prevent downloading all pdf's when installing pdfminer.six #364

merged 4 commits into from
Jan 24, 2020

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Jan 24, 2020 •
edited
Loading

Description

@davidcornewell detected a possible security thread in one of the sample pdf's. It looks like the pdf has some "javascript enabled object" that can execute malicious code.

I did not check if that actually happens, but I just removed the file from the samples directory. And also I have removed the whole samples directory from the source distribution package because these samples are for testing.

Explanation of thread: malware encyclopedia

Fixes #363

How Has This Been Tested?

I've checked if the file is indeed infected using an online virus scanner.

Checklist

  • I have added tests that prove my fix is effective or that my feature works, or I am sure that this is not necessary.
  • I have updated the README.md and other documentation, or I am sure that this is not necessary
  • I have added a consice human-readable description of the change to CHANGELOG.md
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial version

@pietermarsman pietermarsman changed the title Fix 363 remove pdf from sdist Remove samples/ directory from source distribution to prevent downloading all pdf's when installing pdfminer.six Jan 24, 2020
@pietermarsman pietermarsman merged commit 1c3047b into develop Jan 24, 2020
@pietermarsman pietermarsman deleted the fix-363-remove-pdf-from-sdist branch February 2, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Security reported a virus
1 participant
@pietermarsman