Fix converting path to multiple rectangles #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For path that consists of a series of rectangles (shape is 'mlllhmlllh...'), call paint_path again with each group of 5 points. The result is multiple rects instead of a single curve. fixes pdfminer#369
cheungpat
force-pushed
the
path-multiple-rects
branch
from
8fdc37e
to
80dbb3b
Compare
pietermarsman
requested changes
Mar 14, 2020
There was a problem hiding this comment.
Your code changes look good!
I would like to have some unittests for this, instead of a PDF integration test.
A suggestion: could you add a reference in the docstring of paint_path() to the Section 4.4 of the PDF Reference ("Path Construction and Painting") makes it easier for everyone to understand this method.
|
@cheungpat this is a friendly reminder that this PR still needs some work :) |
pietermarsman
approved these changes
Jul 11, 2020
|
@cheungpat Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For path that consists of a series of rectangles (shape is 'mlllhmlllh...'), call paint_path again with each group of 5 points. The result is multiple rects instead of a single curve.
This fixes #369 which affects PDF generated from Excel and Microsoft Print to PDF. The PDF generated by this method will have borders drawn using a single path instead of multiple rectangles. This allows tables to be drawn as expected when using
pdf2txt -t htmland also when usingpdfplumber(which does not consider rect edges from curves).Fixes #369
How Has This Been Tested?
Added a test case to parse such PDF and inspect the changes by calling
pdf2txt -t html <pdf>before/after the change. Thepdf2txt -t xmlwill also generate<rect>instead of<curve>Checklist