Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused rijndael encryption #465

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Remove unused rijndael encryption #465

merged 3 commits into from
Sep 10, 2020

Conversation

igormp
Copy link
Contributor

@igormp igormp commented Aug 1, 2020

Removing unused rijndael encryption, since the cryptography package is already imported and favored over it.

Fixes #464

Checklist

  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or I am verified that this
    is not necessary
  • I have updated the readthedocs documentation or I
    verified that this is not necessary
  • I have added a consice human-readable description of the change to
    CHANGELOG.md

jstockwin
jstockwin approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@jstockwin jstockwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pietermarsman
Copy link
Member

@igormp thanks!

@pietermarsman pietermarsman merged commit a83f853 into pdfminer:develop Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstockwin jstockwin jstockwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused rijndael encryption
3 participants
@igormp @pietermarsman @jstockwin