Quick fix to enable switching caching on and off #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables caching to be turned on and off rather than be always on regardless of the user input.
danich1
changed the title
jstockwin
requested changes
Aug 24, 2020
There was a problem hiding this comment.
Hey @danich1! Thanks for submitting a fix.
This looks good to me, but we'll wait for @pietermarsman's green-light before merging.
One small thing: please could you update the CHANGELOG file to reflect the fix?
|
Changed the CHANGELOG.md to reflect my fix. Hope this helps! |
pietermarsman
approved these changes
Sep 10, 2020
|
@danich1 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #474
This is a quick fix for a bug mentioned in #474.
To reiterate: high_level script that makes
extract_textandextract_pagesalways use caching despite the user's preference.This PR fixes that issue and updates the parameters and in-code documentation to be consistent with
extract_text_to_fp.