-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #469 is fixed (When run on Windows a lot of tests fail with the error: [Errno 13] Permission denied) #484
Conversation
Hi @Ev2geny, good catch! I've left a comment on the issue with some comments on the proposed solution. Could you change the PR to reflect that? What I'm suggesting is to create a new context manager If you don't know context managers (that's what the |
@pietermarsman , I think this is logical to do. I will re-write PR with context manager TemporaryFilePath() |
Yep, lets wait for #503. The error is caused because prefix and suffix are directly added to the filename. I guess the default values are different in python 3.4 (e.g. empty string). |
I removed python 3.4 from the following release. Could you rebase on develop and force push? |
|
Thanks! |
… error: [Errno 13] Permission denied) (#484) Closes #469 * Issue #469 is fixed * one extra comment to code is added * TemporaryFilePath context manager is added to facilitate tests * flake8 complaints fixed * Update docs of tempfilepath.py * Fix flake8 Co-authored-by: Pieter Marsman <pietermarsman@gmail.com>
Pull request
This fixes issue
When run on Windows a lot of tests fail with the error: [Errno 13] Permission denied #469
Both detailed problem analysis as well as the solution implemented are described in #469
How Has This Been Tested?
I ran tests in Windows 10 environment and they all pass now
Checklist
works
version -
is not necessary
verified that this is not necessary
CHANGELOG.md