Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a pathlib.PurePath object as a input to open_filename #492

Merged
merged 11 commits into from
Sep 17, 2020
Merged

Allow a pathlib.PurePath object as a input to open_filename #492

merged 11 commits into from
Sep 17, 2020

Conversation

estshorter
Copy link
Contributor

Pull request

This resolves #491

How Has This Been Tested?

Tests added in this PR will verify my changes.

Checklist

  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or I am verified that this
    is not necessary
  • I have updated the readthedocs documentation or I
    verified that this is not necessary
  • I have added a consice human-readable description of the change to
    CHANGELOG.md

@estshorter estshorter changed the title open_filename accepts a pathlib.PurePath object Allow a pathlib.PurePath object as a input of open_filename Sep 9, 2020
@estshorter estshorter changed the title Allow a pathlib.PurePath object as a input of open_filename Allow a pathlib.PurePath object as a input to open_filename Sep 9, 2020
@estshorter estshorter changed the title Allow a pathlib.PurePath object as a input to open_filename Allow a pathlib.PurePath object as a input to open_filename Sep 11, 2020
pietermarsman
pietermarsman requested changes Sep 12, 2020
View reviewed changes
pdfminer/utils.py Show resolved Hide resolved
tests/test_highlevel_extracttext.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pietermarsman
pietermarsman requested changes Sep 13, 2020
View reviewed changes
Copy link
Member

@pietermarsman pietermarsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done :)

pdfminer/utils.py Show resolved Hide resolved
pietermarsman
pietermarsman approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@pietermarsman pietermarsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estshorter Thanks for all the work!

@pietermarsman pietermarsman merged commit f03657e into pdfminer:develop Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietermarsman pietermarsman pietermarsman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open_filename doesn't accept a pathlib object
2 participants
@estshorter @pietermarsman