Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 3.4 and 3.5 #507

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Deprecate Python 3.4 and 3.5 #507

merged 1 commit into from
Oct 10, 2020

Conversation

estshorter
Copy link
Contributor

@estshorter estshorter commented Sep 21, 2020

Pull request

For issue #503
This code is based on 3fbaa57.

How Has This Been Tested?

I tested in my environment.

Checklist

  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or I am verified that this
    is not necessary
  • I have updated the readthedocs documentation or I
    verified that this is not necessary
  • I have added a consice human-readable description of the change to
    CHANGELOG.md

@Ev2geny
Copy link

Ev2geny commented Sep 26, 2020

Hello, I think also this line needs to be updated

envlist = py{34,35,36,37,38}

@estshorter
Copy link
Contributor Author

I think tests should be removed after dropping support.

@pietermarsman pietermarsman merged commit 360b1ef into pdfminer:develop Oct 10, 2020
@flywire
Copy link

flywire commented May 28, 2021

Why deprecate Python 3.4 and 3.5? What were there issues?

@estshorter
Copy link
Contributor Author

Did you see #503 ?
Because it takes effort to support ancient Python (3.5 and earlier).
For example, we cannot use useful syntax like f-string in those versions.

@flywire
Copy link

flywire commented May 28, 2021

OK, suggest add End of support comment: https://www.python.org/downloads/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants