Fix .paint_path bug noted in issue #473 #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvine
force-pushed
the
fix-paint-path
branch
from
1edf26a
to
d468709
Compare
Focuses on the handling of non-rect quadrilaterals, the decomposition of complex (m.*h)* paths into subpaths, and assigning those subpaths the correct LTCurve/LTRect type. Also adds a test for cases presented in issue pdfminer#473
jsvine
force-pushed
the
fix-paint-path
branch
from
d468709
to
eefccc2
Compare
pietermarsman
requested changes
Oct 10, 2020
|
@jsvine I think the code looks good. The tests look really good :). I suggested some minor changes. |
- Adjusts logic to adhere to if-elif-else rather than early returns. - Shortens subpath detection/reprocessing step, using re.finditer().
jsvine
commented
Oct 12, 2020
|
Thanks, @pietermarsman. The reordering of the logic makes general sense to me, but |
pietermarsman
approved these changes
Oct 12, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #473 for details. Focuses on the handling of non-rect quadrilaterals, the decomposition of complex (m.h) paths into subpaths, and assigning those subpaths the correct LTCurve/LTRect type.
Pull request
Thanks for improving pdfminer.six! Please include the following information to
help us discuss and merge this PR:
A description of why this PR is needed. What does it fix? What does it improve?
Please see #473 for details.
A summary of the things that this PR changes.
This PR partially rewrites
PDFLayoutAnalyzer.paint_path(...), and also adds a test totests/test_converter.py.How Has This Been Tested?
See changes to
tests/test_converter.py, with more context available in #473Checklist
works
version
is not necessary
verified that this is not necessary
CHANGELOG.md