Remove supoprt for non standard output streams that are not binary by removing the try-except check that writes a unicode character to the stream #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… removing the try-except check that writes a unicode character to the stream
pietermarsman
force-pushed
the
191-remove-try-except-check-for-output-stream
branch
from
d812e8b
to
6c51ce4
Compare
pietermarsman
deleted the
191-remove-try-except-check-for-output-stream
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Closes #191
How Has This Been Tested?
Added test for all the streams that we support / know.
Checklist
works
version
is not necessary
verified that this is not necessary
CHANGELOG.md