Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value error and key error #574

Merged

Conversation

tongbaojia
Copy link
Contributor

@tongbaojia tongbaojia commented Jan 27, 2021

How Has This Been Tested?
Can confirm that with these fixes the document can be processed.

Checklist

  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or I am verified that this
    is not necessary
  • I have updated the readthedocs documentation or I
    verified that this is not necessary
  • I have added a consice human-readable description of the change to
    CHANGELOG.md

Copy link
Member

@pietermarsman pietermarsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good and harmless. Can you add a FIxes line to the CHANGELOG.md?

@tongbaojia
Copy link
Contributor Author

I updated the CHANGELOG. but @pietermarsman something is wrong with the bot running the test?

@tongbaojia
Copy link
Contributor Author

The bot raises:

py36 inst: /home/travis/build/pdfminer/pdfminer.six/.tox/.tmp/package/1/pdfminer.six-20201018.zip
ERROR: invocation failed (exit code 1), logfile: /home/travis/build/pdfminer/pdfminer.six/.tox/py36/log/py36-1.log

@pietermarsman
Copy link
Member

Can you merge/rebase with the develop branch? This will fix the cicd failure.

@tongbaojia
Copy link
Contributor Author

@pietermarsman is this PR ready to merge? Thanks :)

@pietermarsman pietermarsman merged commit 543976f into pdfminer:develop Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants