625 support identity cmap #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix cryptography build in travis cicd by upgrading distribution from …
Use python3.9 in tox config
pietermarsman
requested changes
Sep 17, 2021
There was a problem hiding this comment.
Looks good! Indeed fixes the issue with the mentioned PDF.
I've requested some changes, only esthetics.
I'm also interested in a MR with the changes in https://github.com/wind-chh/pdfminer.six/tree/598-support-cmap-type-6-10-12, are you also up for that?
|
@wind-chh friendly reminder that there is some esthetics work left here. |
…to 625-support-identity-cmap
…ner.six into 625-support-identity-cmap
This is a quick fix, the entire cmap structure does not have proper inheritance.
pietermarsman
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
This PR try to fix issue (#625 ). As PDFBox can handle this kind of pdf but pdfminer.six cannot. I add a similar process as PDFBox.
How Has This Been Tested?
I've added the failure pdf file under sample/contrib and a test case
in test_highlevel_extracttext.py testsuite. All unittests passed on my environment.
Checklist
works
version
is not necessary
verified that this is not necessary
CHANGELOG.md