Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes jbig2 writer to write valid jb2 files #653

Closed
wants to merge 3 commits into from
Closed

Fixes jbig2 writer to write valid jb2 files #653

wants to merge 3 commits into from

Conversation

fgregg
Copy link

@fgregg fgregg commented Aug 2, 2021 •
edited
Loading

Pull request

How Has This Been Tested?

Ran

> pd2txt.py --output-dir=. samples/contrib/pdf-with-jbig2.pdf
> ls *.jb2
XIPLAYER0.jb2
> jbig2dec -t pbm XIPLAYER0.jb2
> pnmtopng XIPLAYER0.pbm > XIPLAYER0.png

which outputs a good PNG.

Checklist

  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or I am verified that this
    is not necessary
  • I have updated the readthedocs documentation or I
    verified that this is not necessary
  • I have added a consice human-readable description of the change to
    CHANGELOG.md

@fgregg fgregg mentioned this pull request Aug 2, 2021
Closed
pietermarsman added a commit that referenced this pull request Jan 23, 2022
@pietermarsman
Fixes jbig2 writer to write valid jb2 files
aa5dec2 
See: #653

Squashed commit of the following:

commit 8748c9f
Author: Pieter Marsman <pietermarsman@gmail.com>
Date:   Sun Jan 23 21:40:50 2022 +0100

    Remove prints in test

commit bb97725
Author: Pieter Marsman <pietermarsman@gmail.com>
Date:   Sun Jan 23 21:35:12 2022 +0100

    Cleanup exception handling for jbig2 global streams

commit cf0b47b
Merge: a5831d1 708dd20
Author: Pieter Marsman <pietermarsman@gmail.com>
Date:   Sun Jan 23 21:29:15 2022 +0100

    Merge branch 'develop' into jbig2_fix

commit a5831d1
Author: Forest Gregg <fgregg@datamade.us>
Date:   Sun Aug 1 22:59:17 2021 -0400

    flake8 tests

commit 18ffa29
Author: Forest Gregg <fgregg@datamade.us>
Date:   Sun Aug 1 22:52:11 2021 -0400

    add description in changelog

commit 6c7ee43
Author: Forest Gregg <fgregg@datamade.us>
Date:   Sun Aug 1 22:43:36 2021 -0400

    Fixes jbig2 writer to write valid jb2 files

    - closes #652
@pietermarsman
Copy link
Member

@fgregg Thanks for this!

In advance, can you make sure that contributors can also commit to your branches? Now I have to merge this with a separate merge commit, and it isn't directly related to this PR.

Merged in aa5dec2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jbig2 extractor does not seem to be working correctly
2 participants
@fgregg @pietermarsman