Refactor ImageWriter and add method for exporting an image from bytes. #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietermarsman
force-pushed
the
434-extract-flate-decode
branch
from
6987004
to
526f20b
Compare
E.g. when FlateDecode just results in a list of RGB bytes.
pietermarsman
force-pushed
the
434-extract-flate-decode
branch
from
526f20b
to
b71477c
Compare
jstockwin
approved these changes
Mar 22, 2022
Beants
added a commit
to HiTalentAlgorithms/pdfminer.six
that referenced
this pull request
Apr 26, 2022
* commit '1bf3c42b59125f4491d863e1c11dca7ebbe96adc': Use charset-normalizer instead of chardet (pdfminer#744) Refactor ImageWriter and add method for exporting an image from bytes. (pdfminer#737) Log warning and continue gracefully if errors in cmap (pdfminer#731) Fix log.debug statement in lzw.py by ensuring that self.table is always set (pdfminer#732) Raise KeyError when name in name2unicode is not of type str (pdfminer#733) Convert fontname to str if it is bytes in HTMLConverter (pdfminer#734) Fix github actions tag regex Fix github actions tag regex Bump version Add github action for releasing to pypi if git tag is added. (pdfminer#727)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Fixes #434. All images from that related PDF are now properly extracted.
Refactor ImageWriter and add method for exporting an image from bytes. E.g. when FlateDecode just results in a list of RGB bytes.
Also removed outputting the image size as part of the path name. Not sure what the goal for that is. This will break code that is expecting a specific image name. But the proper way to do that is to use
ImageWriteras a user and use the output name. So I'm ok with changing this.How Has This Been Tested?
With the PDF in the issue. Test cases still succeed. All existing code is refactored but should not have changed.
Checklist
works
version
is not necessary
verified that this is not necessary
CHANGELOG.md