Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to docs how to resolve target page of outlines entries #825

Merged
merged 5 commits into from
Dec 29, 2023

Conversation

dmlls
Copy link
Contributor

@dmlls dmlls commented Oct 28, 2022

Pull request

This PR adds to the docs how to resolve the target page number of Outlines entries. In #813 it has been raised whether this should be directly exposed by pdfminer.six, but since it's still unclear whether this will happen, at least we can provide a way of doing it in the current state of things.

How Has This Been Tested?

I've tested the code snippets included in the added documentation with 290 PDF documents. Unfortunately, I will have to stick to the classic "I cannot share these documents." But here there is a Colab with a few docs.

The only thing I have not be able to test is SE entries since I haven't been able to find any doc containing them. If anyone can provide such document I'd be happy to test that too.

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@dmlls dmlls marked this pull request as ready for review October 28, 2022 14:13
@pietermarsman pietermarsman added this pull request to the merge queue Dec 29, 2023
@pietermarsman
Copy link
Member

And thanks again! Looks great!

Merged via the queue into pdfminer:master with commit 8bb1d11 Dec 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants