Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#833 PDFObj instead of int #834

Merged
merged 7 commits into from
Dec 29, 2023
Merged

#833 PDFObj instead of int #834

merged 7 commits into from
Dec 29, 2023

Conversation

gosiafilipek
Copy link
Contributor

@gosiafilipek gosiafilipek commented Nov 17, 2022 •
edited by pietermarsman
Loading

resolve1 on elements of self.attr['MediaBox'] in pdfpage
resolve1 on width in pdffont

Closes #833

resolve1 on width in pdffont
0ad15e2 
resolve1 on elements of self.attr['MediaBox'] in pdfpage
@gosiafilipek gosiafilipek mentioned this pull request Nov 29, 2022
Closed
@KunalGehlot
Copy link
Contributor

Looks like some tests failed.
Try running nox to fix these issues.

@gosiafilipek
Copy link
Contributor Author

@KunalGehlot
I run nox and pushed changes.
There are still one test failed, but I didn't change that part of code.
image
Do you have any suggestions what can I do to fix it?

@gosiafilipek
Copy link
Contributor Author

@KunalGehlot I run nox and pushed changes. There are still one test failed, but I didn't change that part of code. image Do you have any suggestions what can I do to fix it?

@pietermarsman @KunalGehlot any advice?

@pietermarsman
Copy link
Member

Thanks for this fix!

@pietermarsman pietermarsman added this pull request to the merge queue Dec 29, 2023
@pietermarsman pietermarsman removed this pull request from the merge queue due to a manual request Dec 29, 2023
@pietermarsman pietermarsman added this pull request to the merge queue Dec 29, 2023
Merged via the queue into pdfminer:master with commit dba5cc8 Dec 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDFObjRef instead of int
3 participants
@gosiafilipek @KunalGehlot @pietermarsman