Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize (#911) #912

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Optimize (#911) #912

merged 2 commits into from
Jun 24, 2024

Conversation

mitchelljkotler
Copy link
Contributor

@mitchelljkotler mitchelljkotler commented Oct 13, 2023 •
edited
Loading

Pull request

This closes #911, optimizing the apply_png_predictor, reducing the time from 29 minutes to 4 seconds on a particular PDF I have.

How Has This Been Tested?

I ran the test suite

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

pietermarsman
pietermarsman approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@pietermarsman pietermarsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I want to merge it, but there are merge conflicts and I am not allowed to push to your branch. Can you fix them?

CHANGELOG.md Outdated Show resolved Hide resolved
@pietermarsman
Copy link
Member

@mitchelljkotler Thanks for the update! There is still one test failing.

@mitchelljkotler
Copy link
Contributor Author

@mitchelljkotler Thanks for the update! There is still one test failing.

I fixed the mypy check.. Now the docs are failing to build, but I believe that is unrelated?

@pietermarsman
Copy link
Member

Yep, I fixed that in 9cc4d1d.

So merging.

@pietermarsman pietermarsman added this pull request to the merge queue Jun 24, 2024
Merged via the queue into pdfminer:master with commit 0e9673d Jun 24, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietermarsman pietermarsman pietermarsman approved these changes

Assignees
No one assigned
Labels
status: accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize apply_png_predictor
2 participants
@mitchelljkotler @pietermarsman