Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimally fix CI #921

Merged
merged 9 commits into from
Nov 24, 2023
Merged

Minimally fix CI #921

merged 9 commits into from
Nov 24, 2023

Conversation

dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Nov 15, 2023

Pull request

Python versions in CI were very out of date - 3.6 and 3.7 are now end-of-life and no longer supported. See https://devguide.python.org/versions/

But beyond that a lot of things passed CI only because of specific older versions of tooling (black, mypy, pip among other things). These problems should be fixed for real but this will at least get CI working again. I will separate PRs for these problems, which are partly formatting but also some type-checking issues (there are quite a lot of type-checking issues) and of course the issue of -VERSION- as the default version string (really there should be a way to get to semantic versioning...)

How Has This Been Tested?

It wasn't tested when first pushed because there isn't any easy way to test GitHub CI recipes 😡 But now it seems to work :)

Checklist

  • [ x ] I have read CONTRIBUTING.md.
  • [ x ] I have added a concise human-readable description of the change to CHANGELOG.md.
  • [ x ] I have tested that this fix is effective or that this feature works.
  • [ x ] I have added docstrings to newly created methods and classes. (not applicable)
  • [ x ] I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary. (not applicable)

@dhdaines dhdaines mentioned this pull request Nov 15, 2023
@dhdaines dhdaines changed the title Fix CI by updating list of Python versions to currently supported ones Minimally fix CI by requiring old versions that tolerate bogosity Nov 15, 2023
@dhdaines dhdaines changed the title Minimally fix CI by requiring old versions that tolerate bogosity Minimally fix CI Nov 15, 2023
@pietermarsman
Copy link
Member

@dhdaines Thanks for this work! This is a great start to do some more work on pdfminer.six in the nearby future.

@pietermarsman pietermarsman added this pull request to the merge queue Nov 24, 2023
Merged via the queue into pdfminer:master with commit 40b200d Nov 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants