Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setuptools-git-versioning 2.x #957

Merged

Conversation

musicinmybrain
Copy link
Contributor

@musicinmybrain musicinmybrain commented Apr 11, 2024

Pull request

Allow the current release of setuptools-git-versioning (2.0.0) by raising the version bound from <2 to <3. (I did not file an issue for this.)

Version 2.0.0 has several breaking changes, described in https://setuptools-git-versioning.readthedocs.io/en/stable/changelog.html#change-2.0.0, but none of them appear relevant for this project.

How Has This Been Tested?

$ python3 -m build
$ cd dist
$ ls -1
pdfminer.six-20221105.post23+git.f02a1b80-py3-none-any.whl
pdfminer.six-20221105.post23+git.f02a1b80.tar.gz
$ python3 -m wheel unpack pdfminer.six-20221105.post23+git.f02a1b80-py3-none-any.whl
$ grep -E '^Version:' pdfminer.six-20221105.post23+git.f02a1b80/pdfminer.six-20221105.post23+git.f02a1b80.dist-info/METADATA 
Version: 20221105.post23+git.f02a1b80

https://setuptools-git-versioning.readthedocs.io/en/stable/changelog.html#change-2.0.0

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes. N/A, no code changes
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@pietermarsman
Copy link
Member

Thanks for your contribution!

Merged via the queue into pdfminer:master with commit ae39350 Jun 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants