Support prereleases in python requires #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #932 +/- ##
==========================================
+ Coverage 83.87% 83.99% +0.11%
==========================================
Files 74 74
Lines 6461 6471 +10
Branches 1341 1342 +1
==========================================
+ Hits 5419 5435 +16
+ Misses 715 711 -4
+ Partials 327 325 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hnasar
pushed a commit
to Hnasar/pdm
that referenced
this pull request
Jun 3, 2022
Since prereleases are now supported in python specifiers (in the previous commit), we can remove the workaround (from commit 8e72609 for pdm-project#932) that converted a python prerelease version to a specifier range.
frostming
pushed a commit
that referenced
this pull request
Jun 3, 2022
…1112) * Fix crash if dependencies have prerelease requires-python versions Recently, coverage 6.4.1 listed its requirements with an alpha version of python and this broke PDM's version parsing: extras_require={ 'toml': ['tomli; python_full_version<="3.11.0a6"'], }, Prerelease `requires-python` versions *are* valid, per these specifications: * https://peps.python.org/pep-0440/ * https://peps.python.org/pep-0621/#requires-python * https://packaging.python.org/en/latest/specifications/core-metadata/#requires-python Therefore this commit adds missing parsing support for `{a|b|rc}[N]` pre-release specifiers which are used by python language releases: * https://docs.python.org/3/faq/general.html#how-does-the-python-version-numbering-scheme-work This bug meant that projects that directly or indirectly depended on coverage were unable to update pdm.lock using commands like `update` `add` `lock` and `install` because `pdm.models.versions.Version` would raise: pdm.exceptions.InvalidPyVersion: 3.11.0a6: Prereleases or postreleases are not supported for python version specifers. Until this is fixed, projects can workaround this by depending on: "coverage<6.4", "coverage[toml]<6.4", Fixes #1111 * Remove workaround for pre-release python in global environment Since prereleases are now supported in python specifiers (in the previous commit), we can remove the workaround (from commit 8e72609 for #932) that converted a python prerelease version to a specifier range. Co-authored-by: Hashem Nasarat <hnasarat@beta.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
news/describing what is new.Describe what you have changed in this PR.