Fixes and test for release v0.4 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the PDS Interop-wide PHP project updates: - Remove unneeded platform config - Set minimum PHP version to PHP 7.3 (but lower than PHP8, see pdsinterop/php-solid-auth#19) - Pin PHPUnit to v8 and v9
This will trigger configuration validation warnings. The config may need to be split into separate files for PHPUnit 8 and 9.
This allows for easier re-use and improves fault tolerance. Readability improvement is still under discussion.
- Test for when $filesystem->read($path) returns false - Test for when $converter->parse(...) throws EasyRdf_Exception - Test for when $converter->parse(...) output is non-scalar
- PSR-12 whitespace fixes - Namespace fixes - Divider comments
- The `read()` method adds more metadata when contents is converted, as content needs to be read anyway when getting metadata for another format - Various "meta" methods (`has()`, `getSize()`) now proxy getMetadata() instead of calling parent to facilitate converted content - The `getMimetype()` method can be used separately from reading file content - Make test more specific regarding proxy or logic of method under test
- Change variable name to something more descriptive - Add Comment explaining use of array_filter - Add TODO marker for fixing long test names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request is mainly about adding correct logic for
getMetadata, as that is needed for the server-side implementation of Solid Link Metadata.In order to support those changes, unit-tests have been added. Besides this, some cleanup has also taken place.
Fixes #4.
Because of time constraints, this MR might be merged before review, with any changes based on comments added after the fact.