Updated easyRDF to version 1.1.1 so we can support php8. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potherca
reviewed
May 30, 2022
.github/workflows/tests.yml
Outdated
| @@ -11,7 +11,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| php: ['7.3', '7.4'] | |||
| php: ['8.0'] | |||
There was a problem hiding this comment.
See comment about PHP versions in composer.json
Potherca
approved these changes
May 31, 2022
|
some of the tests seem to be failing 🤔 |
Potherca
approved these changes
Aug 22, 2022
|
Merging this as part of upgrading all packages, will look into the failing tests and follow up with a fix if needed. |
|
Broken tests resolved in 2293045. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.