Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper replay protection #68

Open
michielbdejong opened this issue Sep 1, 2023 · 1 comment
Open

Add proper replay protection #68

michielbdejong opened this issue Sep 1, 2023 · 1 comment
Milestone

Comments

@michielbdejong
Copy link
Member

I copied the replay detector from Solid-Nextcloud but this server does not have a database server so I didn't find a good way to store/query previously used JTIs.

I disabled it for now to see if I can get the tests to pass, but at the very least we should implement this with storing the data in some text file or something.

michielbdejong added a commit that referenced this issue Sep 1, 2023
@Potherca
Copy link
Member

Potherca commented Jul 8, 2024

The current storage engine for the PHP Solid Server is "on disk", using FlySystem so "disk" does not have to be a local disk but could also be an AWS S3 bucket, or a Database, etc.

I think ypur first effort (on the test-suite-fixes-2023, adding src/DpopFactoryTrait.php and src/JtiReplayDetector.php, is a good start. (Although we might want to place those files in another location).

@Potherca Potherca added this to the v0.8.0 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants