Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tp-36]-gov-requests #59

Merged
merged 4 commits into from
Dec 15, 2021
Merged

[tp-36]-gov-requests #59

merged 4 commits into from
Dec 15, 2021

Conversation

altNameForStudying
Copy link
Collaborator

  • adds search as main query
  • adds option to search by query
  • adds pagination with default values
  • adds option to filter by model types
  • adds option to sort by title/date/views_count

No image preview - govApi will trigger requests based on view's needs

Will probably get expanded based on Gov tab needs.

@auto-assign auto-assign bot requested a review from pdybowski December 14, 2021 22:38
pdybowski
pdybowski requested changes Dec 14, 2021
View reviewed changes
Copy link
Owner

@pdybowski pdybowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix

src/modules/gov/govApi.js Outdated Show resolved Hide resolved
@pdybowski pdybowski merged commit 60b79a8 into master Dec 15, 2021
@pdybowski pdybowski deleted the tp-36-gov-requests branch December 15, 2021 00:14
@pdybowski pdybowski linked an issue Dec 15, 2021 that may be closed by this pull request
add requests for gov #36
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdybowski pdybowski pdybowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add requests for gov
2 participants
@altNameForStudying @pdybowski