Feat/real api compatible #17
Conversation
| @@ -322,6 +323,11 @@ export const getBlockedAreas = async function* ({ | |||
| payload, | |||
| abortSignal, | |||
| })) { | |||
| if (chunk.result.objects[0].objectId !== '0') { | |||
There was a problem hiding this comment.
Isnt it better to do optional chaining? using ?. or else if data wasn't present it could lead to errors
There was a problem hiding this comment.
Better to check in all the files
| @@ -322,6 +323,11 @@ export const getBlockedAreas = async function* ({ | |||
| payload, | |||
| abortSignal, | |||
| })) { | |||
| if (chunk.result.objects[0].objectId !== '0') { | |||
| objectId = chunk.result.objects[0].objectId; | |||
There was a problem hiding this comment.
Isnt it better to do optional chaining? using ?. or else if data wasn't present it could lead to errors
| objectId = chunk.result.objects[0].objectId; | ||
| continue; | ||
| } | ||
| chunk.result.objects[0].objectId = objectId; |
There was a problem hiding this comment.
Isnt it better to do optional chaining? using ?. or else if data wasn't present it could lead to errors
| @@ -358,6 +371,11 @@ export const getSignalAreas = async function* ({ | |||
| payload, | |||
| abortSignal, | |||
| })) { | |||
| if (chunk.result.objects[0].objectId !== '0') { | |||
There was a problem hiding this comment.
Isnt it better to do optional chaining? using ?. or else if data wasn't present it could lead to errors
| spatialId?: string; | ||
| startTime?: string; | ||
| endTime?: string; | ||
| 'windDirection (degree)': number; |
There was a problem hiding this comment.
I hope its not recommend to name vairables in this manner. better to rename it to windDirectionDegree
There was a problem hiding this comment.
fix in the below other variables as well
| startTime?: string; | ||
| endTime?: string; | ||
| 'windDirection (degree)': number; | ||
| 'windSpeed (knot)': number; |
| ...definition.currentWeather, | ||
| startTime: definition.currentWeather.startTime, | ||
| endTime: definition.currentWeather.endTime, | ||
| 'windDirection (degree)': definition.currentWeather.windDirection, |
There was a problem hiding this comment.
I hope its not recommend to name vairables in this manner. better to rename it to windDirectionDegree
| @@ -20,7 +20,7 @@ interface Props { | |||
| reference: React.RefObject<CesiumComponentRef<Viewer>>; | |||
| } | |||
| const CurrentWeatherViewer = (props: Props) => { | |||
| const [type, setType] = useState<string>('windDirection'); | |||
| const [type, setType] = useState<string>('windDirection (degree)'); | |||
|
@Thiniraxz Merging it due to urgency, please fix and raise another PR |
No description provided.