-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve description of enable_jekyll=disable_nojekyll (see #130) #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
After merging the implementation of enable_jekyll
by me, this pull request will be merged into the master. I will release it as v3.5.0 and update the v3 tag.
Can this description confuse users who use Jekyll on Docker? Actually, they do not need |
The current description mentions I came to think that we do not have to refer to the role of the |
How about |
That's clearer than When deploying, users only care about whether Jekyll processing is enabled or not, They don't actually care what semaphore mechanism is used to achieve this (the |
Thanks to your great work, the description became more clear! LGTM. After merging the implementation of |
This assumes
enable_jekyll
is implemented as (the preferred) alias fordisable_nojekyll
(see #130).