-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump to use node20 runtime #641
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
cc @peaceiris (it would also need a major release 3.0.0 after the PR merge) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
It will be released as the first version of 2024 together with other bug fixes! ʕ◔ϖ◔ʔ |
Signed-off-by: Rui Chen <rui@chenrui.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 9445 lines exceeds the maximum allowed for the inline comments feature.
looks like CI is not happy with the dist artifact checkin, I will move it into separate PR. |
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
This reverts commit 6ed77e1.
Any ETA for its release? |
Thank you so much! ʕ◔ϖ◔ʔ |
do we need to wait for a major version release as well? |
`peaceiris/actions-hugo#642 also mentioned `peaceiris/actions-hugo#641, which was merged to main branch as `https://github.com/peaceiris/actions-hugo/commit/c57490a8b04136ae58ab5866a93d3db2f0fa0945`; the implication is that `@c57490a8b04136ae58ab5866a93d3db2f0fa0945` may be able to reference that internal commit
@peaceiris we need a major version release per this merge. |
The tag v3.0.0 was released last week. The v3 tag is also available. ʕ◔ϖ◔ʔ https://github.com/peaceiris/actions-hugo/releases/tag/v3.0.0 |
This is consistent with all the recent github action updates. (mostly in actions repos, like actions/checkout, actions/setup-node, etc.)
Node12 was deleted from runner. Node20 was added to Actions Runner on v2.308.0.
Node16 has en end of life on 11 Sep 2023.
This PR updates the default runtime to node20, rather then node16
relates to actions/runner#2732