fix: Wrap an entrypoint by async to handle exceptions correctly #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Also related to #310 |
peaceiris
previously approved these changes
Jun 21, 2020
peaceiris
force-pushed
the
feature/fix_async_toplevel
branch
from
536219d to
3a8a880
Compare
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 127 127
Branches 14 14
=========================================
Hits 127 127 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I tried to fix #362.
Thank you for your great GitHub Action and active maintenance 🙏