Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw error for invalid extended input #387

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

peaceiris
Copy link
Owner

@peaceiris peaceiris commented Jul 17, 2020

  • test: Add invalid case

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #387 into main will decrease coverage by 0.79%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #387      +/-   ##
===========================================
- Coverage   100.00%   99.20%   -0.80%     
===========================================
  Files            6        6              
  Lines          124      126       +2     
  Branches        14       15       +1     
===========================================
+ Hits           124      125       +1     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/get-url.ts 93.33% <50.00%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2d546...28797ce. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant