-
Notifications
You must be signed in to change notification settings - Fork 233
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
command/storage: add versioning support (#475)
This commit adds versioning support to the s5cmd. Added --all-versions flag to ls, rm, du and select subcommands to apply operation on(/over) all versions of the objects. Added --version-id flag to cat, cp/mv, rm, du and select subcommands to apply operation on(/over) a specific versions of the object. Added bucket-version command to configure bucket versioning. Bucket name alone returns the bucket versioning status of the bucket. Bucket versioning can be configured with set flag which only accepts. Added --raw flag to cat and select subcommands. It disables the wildcard operations. Note: Google Cloud Storage uses a different approach for versioning. So with current implementation, s5cmd cannot use or retrieve generation numbers . However, bucket-version command and du command with all-versions flag works as expected since they do not use version ids. Fixes: #218 Fixes: #386 Fixes: #539
- Loading branch information
1 parent
f0ce87d
commit 0993c6d
Showing
27 changed files
with
1,348 additions
and
152 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| package command | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/urfave/cli/v2" | ||
|
|
||
| "github.com/peak/s5cmd/log" | ||
| "github.com/peak/s5cmd/storage" | ||
| "github.com/peak/s5cmd/storage/url" | ||
| "github.com/peak/s5cmd/strutil" | ||
| ) | ||
|
|
||
| var bucketVersionHelpTemplate = `Name: | ||
| {{.HelpName}} - {{.Usage}} | ||
| Usage: | ||
| {{.HelpName}} [options] s3://bucketname | ||
| Options: | ||
| {{range .VisibleFlags}}{{.}} | ||
| {{end}} | ||
| Examples: | ||
| 1. Get bucket versioning status of a bucket | ||
| > s5cmd {{.HelpName}} s3://bucketname | ||
| 2. Enable bucket versioning for the bucket | ||
| > s5cmd {{.HelpName}} --set Enabled s3://bucketname | ||
| 3. Suspend bucket versioning for the bucket | ||
| > s5cmd {{.HelpName}} --set Suspended s3://bucketname | ||
| ` | ||
|
|
||
| func NewBucketVersionCommand() *cli.Command { | ||
| cmd := &cli.Command{ | ||
| Name: "bucket-version", | ||
| CustomHelpTemplate: bucketVersionHelpTemplate, | ||
| HelpName: "bucket-version", | ||
| Usage: "configure bucket versioning", | ||
| Flags: []cli.Flag{ | ||
| &cli.GenericFlag{ | ||
| Name: "set", | ||
| Value: &EnumValue{ | ||
| Enum: []string{"Suspended", "Enabled"}, | ||
| Default: "", | ||
| ConditionFunction: strings.EqualFold, | ||
| }, | ||
| Usage: "set versioning status of bucket: (Suspended, Enabled)", | ||
| }, | ||
| }, | ||
| Before: func(ctx *cli.Context) error { | ||
| if err := checkNumberOfArguments(ctx, 1, 1); err != nil { | ||
| printError(commandFromContext(ctx), ctx.Command.Name, err) | ||
| return err | ||
| } | ||
| return nil | ||
| }, | ||
| Action: func(c *cli.Context) error { | ||
| status := c.String("set") | ||
|
|
||
| fullCommand := commandFromContext(c) | ||
|
|
||
| bucket, err := url.New(c.Args().First()) | ||
| if err != nil { | ||
| printError(fullCommand, c.Command.Name, err) | ||
| return err | ||
| } | ||
|
|
||
| return BucketVersion{ | ||
| src: bucket, | ||
| op: c.Command.Name, | ||
| fullCommand: fullCommand, | ||
|
|
||
| status: status, | ||
| storageOpts: NewStorageOpts(c), | ||
| }.Run(c.Context) | ||
| }, | ||
| } | ||
| cmd.BashComplete = getBashCompleteFn(cmd, true, true) | ||
| return cmd | ||
| } | ||
|
|
||
| type BucketVersion struct { | ||
| src *url.URL | ||
| op string | ||
| fullCommand string | ||
|
|
||
| status string | ||
| storageOpts storage.Options | ||
| } | ||
|
|
||
| func (v BucketVersion) Run(ctx context.Context) error { | ||
| client, err := storage.NewRemoteClient(ctx, &url.URL{}, v.storageOpts) | ||
| if err != nil { | ||
| printError(v.fullCommand, v.op, err) | ||
| return err | ||
| } | ||
|
|
||
| if v.status != "" { | ||
| v.status = strutil.CapitalizeFirstRune(v.status) | ||
|
|
||
| err := client.SetBucketVersioning(ctx, v.status, v.src.Bucket) | ||
| if err != nil { | ||
| printError(v.fullCommand, v.op, err) | ||
| return err | ||
| } | ||
| msg := BucketVersionMessage{ | ||
| Bucket: v.src.Bucket, | ||
| Status: v.status, | ||
| isSet: true, | ||
| } | ||
| log.Info(msg) | ||
| return nil | ||
| } | ||
|
|
||
| status, err := client.GetBucketVersioning(ctx, v.src.Bucket) | ||
| if err != nil { | ||
| printError(v.fullCommand, v.op, err) | ||
| return err | ||
| } | ||
|
|
||
| msg := BucketVersionMessage{ | ||
| Bucket: v.src.Bucket, | ||
| Status: status, | ||
| isSet: false, | ||
| } | ||
| log.Info(msg) | ||
| return nil | ||
| } | ||
|
|
||
| type BucketVersionMessage struct { | ||
| Bucket string `json:"bucket"` | ||
| Status string `json:"status"` | ||
| isSet bool | ||
| } | ||
|
|
||
| func (v BucketVersionMessage) String() string { | ||
| if v.isSet { | ||
| return fmt.Sprintf("Bucket versioning for %q is set to %q", v.Bucket, v.Status) | ||
| } | ||
| if v.Status != "" { | ||
| return fmt.Sprintf("Bucket versioning for %q is %q", v.Bucket, v.Status) | ||
| } | ||
| return fmt.Sprintf("%q is an unversioned bucket", v.Bucket) | ||
| } | ||
|
|
||
| func (v BucketVersionMessage) JSON() string { | ||
| return strutil.JSON(v) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.