Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default copy behaviour to --parents #107

Closed
igungor opened this issue Mar 19, 2020 · 1 comment · Fixed by #133
Closed

Change default copy behaviour to --parents #107

igungor opened this issue Mar 19, 2020 · 1 comment · Fixed by #133
Assignees
Milestone

Comments

@igungor
Copy link
Member

igungor commented Mar 19, 2020

Not 100% sure about this, adding this here to track the issue.

Currently s5cmd flattens source directory hiearchy while downloading (cp/mv). For example:

s3://bucket/obj1
s3://bucket/obj2
s3://bucket/01/obj2

s5cmd cp 's3://bucket/*' .

The default behaviour is to find each object recursively, and download them while ignoring all prefixes after the wildcard. Result:

$ ls 

obj1
obj2

There'll be only 1 obj2 but we're not very confident which one.

We should make --parents the default behaviour, and --flatten an option.

@igungor igungor added this to the v1.0.0 milestone Mar 23, 2020
@igungor igungor self-assigned this Mar 26, 2020
@sonmezonur sonmezonur assigned sonmezonur and unassigned igungor Mar 26, 2020
@jackwellsxyz
Copy link

I might also suggest making '-r' an alias for --parents, which would bring s5cmd cp more in line with standard UNIX cp behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants