Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default copy behaviour to preserve directory structure #133

Merged
merged 12 commits into from
Mar 30, 2020
Merged

Change default copy behaviour to preserve directory structure #133

merged 12 commits into from
Mar 30, 2020

Conversation

sonmezonur
Copy link
Member

Resolves #107

@sonmezonur sonmezonur requested a review from igungor March 27, 2020 12:12
igungor
igungor reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@igungor igungor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's use %v in all tests instead of %s.

e2e/cp_test.go Outdated Show resolved Hide resolved
@sonmezonur
Copy link
Member Author

let's use %v in all tests instead of %s.

done

@sonmezonur sonmezonur merged commit 7aa10f4 into master Mar 30, 2020
@sonmezonur sonmezonur deleted the use-parents branch March 30, 2020 13:58
igungor pushed a commit that referenced this pull request Mar 31, 2020
@sonmezonur @igungor
Change default copy behaviour to preserve directory structure (#133)
9b9ea48 
* Add --flatten flag instead of --parents

* Preserve directory structure as a default

* Update Changelog and Readme.md

* Simplify prepareUploadDestination

* Consolidate copy and upload destination url prep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igungor igungor igungor approved these changes

@ilkinulas ilkinulas ilkinulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change default copy behaviour to --parents
3 participants
@sonmezonur @igungor @ilkinulas