Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move homebrew formula into another repository #356

Closed
igungor opened this issue Sep 21, 2021 · 0 comments · Fixed by #429
Closed

Move homebrew formula into another repository #356

igungor opened this issue Sep 21, 2021 · 0 comments · Fixed by #429
Milestone
v2.0.0

Comments

@igungor
Copy link
Member

igungor commented Sep 21, 2021

The main reason is, master branch protection rule in this repo requires pull-requests, approvals, CI checks etc, which is not suitable for goreleaser.

Second reason is, if we keep the formula in a repo with homebrew- prefix, s5cmd brew installation will be a single step, which is nice. For example, if we have homebrew-tap repo with a structure like below:

homebrew-tap
└── Formula
    └── s5cmd.rb

brew install peak/tap/s5cmd will directly install the package from the repo without tapping.

https://docs.brew.sh/Taps#repository-naming-conventions-and-assumptions
@igungor igungor added this to the v2.0.0 milestone Sep 21, 2021
igungor added a commit that referenced this issue Apr 7, 2022
@igungor
goreleaser: move formula to github.com/peak/homebrew-tap repo
e30c639 
This change will affect how users install from homebrew.

Previously, it was:

    brew tap peak/s5cmd https://github.com/peak/s5cmd
    brew install s5cmd

Now it'll be:

    brew install peak/tap/s5cmd

Fixes #356
@igungor igungor mentioned this issue Apr 7, 2022
Merged
igungor added a commit that referenced this issue Apr 8, 2022
@igungor
goreleaser: move formula to github.com/peak/homebrew-tap repo (#429)
0543ca8 
This change will affect how users install from homebrew.

Previously, it was:

    brew tap peak/s5cmd https://github.com/peak/s5cmd
    brew install s5cmd

Now it'll be:

    brew install peak/tap/s5cmd

Fixes #356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

goreleaser: move formula to github.com/peak/homebrew-tap repo peak/s5cmd
1 participant
@igungor