storage/s3: propagate retryable errors from sdk to the user #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonmezonur
requested review from
igungor and
ilkinulas
and removed request for
a team
|
Since s5cmd does not print any logs during the retry period, it misleads users (they don't know what actually happens during execution). For example, this issue is not due to the slow startup of s5cmd, it is because aws sdk getting errors and we don't send any information to the user. ( #244) |
igungor
reviewed
Dec 31, 2020
ilkinulas
approved these changes
Jan 5, 2021
igungor
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be useful to inform the caller for retryable errors. If retryable errors are received during command execution, users should be able to get information about it.