Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps for installation using MacPorts #311

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

manojkarthick
Copy link
Contributor

Hi! I'm a macOS user and I noticed that this tool is available on Homebrew but was missing from MacPorts. So I took the liberty of adding the package. This PR updates the README with installation steps.

Relevant links:

@manojkarthick manojkarthick requested a review from a team as a code owner July 4, 2021 23:32
@manojkarthick manojkarthick requested review from aykutfarsak and sonmezonur and removed request for a team July 4, 2021 23:32
Copy link
Member

@sonmezonur sonmezonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manojkarthick Hello! Thank you for your contribution.

@igungor
Copy link
Member

igungor commented Jul 9, 2021

Our release process (goreleaser under the hood) automatically creates tarballs, updates Docker images and brew formula. Unfortunately it doesn't support macports. That's why it's missing from the readme. Also the fact that the whole team uses brew :)

I don't know much about macports but I see that s5cmd is in the index, so the Portfile needs to be updated after each release, right? I'm not sure we'd do that. If we merge this, we should mention that macports is not officially supported, so updates may fall behind.

@igungor
Copy link
Member

igungor commented Jul 13, 2021

If we merge this, we should mention that macports is not officially supported, so updates may fall behind.

Hi @manojkarthick. Is the above approach sound good to you? If so, would you update the readme please?

@manojkarthick
Copy link
Contributor Author

If we merge this, we should mention that macports is not officially supported, so updates may fall behind.

Hi @manojkarthick. Is the above approach sound good to you? If so, would you update the readme please?

Sounds good @igungor - I've updated the PR with a note on support.

@igungor igungor merged commit c73528f into peak:master Jul 14, 2021
@igungor
Copy link
Member

igungor commented Jul 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants