storage/fs: change order of precedence for URL expansion #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the source URL is both glob and directory,
s5cmd
only copies objects in the directory. Example setup:URL expansion for fs.List() is working like following:
Since
abc*
is a directory, currentlys5cmd
does not try to expand glob. I think we should change the order of precedence for dir/glob expansion.I added tests for both cp/rm commands.