Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: use /aws as working directory #412

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

LadMartin
Copy link
Contributor

Changes relative path to absolute path so a user can easily mount his working dir to the docker
Add empty workdir similar to aws

Changes relative path to absolute path so a user can easily mount his working dir to the docker
Add empty workdir similar to aws
@LadMartin LadMartin requested a review from a team as a code owner February 23, 2022 12:20
@LadMartin LadMartin requested review from ilkinulas and seruman and removed request for a team February 23, 2022 12:20
@LadMartin
Copy link
Contributor Author

It helps when user wants to upload/download local files from/to his workdir.

@seruman seruman added this to the v2.0.0 milestone Mar 25, 2022
Dockerfile Show resolved Hide resolved
Add a note about acessing host filesystem inside docker.
Copy link
Member

@seruman seruman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@seruman seruman changed the title Fix path in docker entrypoint Dockerfile: use /aws as working directory Apr 8, 2022
@seruman seruman merged commit d4aa0cf into peak:master Apr 8, 2022
@LadMartin LadMartin deleted the absolute-path-in-docker-entrypoint branch April 9, 2022 11:53
seruman added a commit that referenced this pull request Apr 11, 2022
seruman added a commit that referenced this pull request Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants