Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile: correctly inject vcs information into the binary #650

Merged
merged 1 commit into from
Aug 23, 2023
Merged

makefile: correctly inject vcs information into the binary #650

merged 1 commit into from
Aug 23, 2023

Conversation

igungor
Copy link
Member

@igungor igungor commented Aug 22, 2023 •
edited
Loading

s5cmd version reports incorrect info due to the package name change.

Before:

$ s5cmd version

v0.0.0-dev

After:

$ ./s5cmd version

v2.2.0-550a8461

@igungor
makefile: correctly inject vcs information into the binary
874ea7a 
`s5cmd version` is reported incorrectly due to the package name change.

Before:
```bash
$ s5cmd version

v0.0.0-dev
```

After:
```bash
$ ./s5cmd version

v2.2.0-550a8461
```
@igungor igungor requested a review from a team as a code owner August 22, 2023 08:31
@igungor igungor requested review from ilkinulas, sonmezonur and seruman and removed request for a team and ilkinulas August 22, 2023 08:31
@igungor igungor merged commit be63977 into master Aug 23, 2023
13 checks passed
@igungor igungor deleted the fix-vcs-embed branch August 23, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seruman seruman seruman approved these changes

@sonmezonur sonmezonur Awaiting requested review from sonmezonur sonmezonur is a code owner automatically assigned from peak/big-data

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igungor @seruman