Fix bug in parsing USERID_HINT status causing missing real user name …

…in BadPassphrases array
pear · Nov 22, 2023 · 0fae3c4 · 0fae3c4
1 parent e38fef2
commit 0fae3c4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/Crypt/GPG/ProcessHandler.php b/Crypt/GPG/ProcessHandler.php
@@ -251,7 +251,7 @@ public function handleStatus($line)
             // remember the user id for pretty exception messages
             // GnuPG 2.1.15 gives me: "USERID_HINT 0000000000000000 [?]"
             $keyId = $tokens[1];
-            if (strcspn($keyId, '0')) {
+            if (preg_match('/[1-9A-F]/', $keyId)) {
                 $username = implode(' ', array_splice($tokens, 2));
                 $this->data['BadPassphrases'][$keyId] = $username;
             }

diff --git a/tests/DecryptTest.php b/tests/DecryptTest.php
@@ -228,8 +228,6 @@ public function testDecryptBadPassphraseException_missing()
      */
     public function testDecryptBadPassphraseException_bad()
     {
-        $this->expectException('Crypt_GPG_BadPassphraseException');
-
         // encrypted with first-keypair@example.com
         // {{{ encrypted data
         $encryptedData = <<<TEXT
@@ -255,8 +253,21 @@ public function testDecryptBadPassphraseException_bad()
 TEXT;
         // }}}
 
-        $this->gpg->addDecryptKey('first-keypair@example.com', 'incorrect');
-        $this->gpg->decrypt($encryptedData);
+        try {
+            $this->gpg->addDecryptKey('first-keypair@example.com', 'incorrect');
+            $this->gpg->decrypt($encryptedData);
+        }
+        catch (\Crypt_GPG_BadPassphraseException $e) {
+            $badKeys = $e->getBadPassphrases();
+            $missingKeys = $e->getMissingPassphrases();
+
+            $this->assertCount(1, $badKeys);
+            $this->assertCount(0, $missingKeys);
+            $this->assertSame(
+                $badKeys[key($badKeys)],
+                "First Keypair Test Key (do not encrypt important data with this key) <first-keypair@example.com>"
+            );
+        }
     }
 
     /**