Skip to content

Commit

Permalink
BugFix: Triggering deprecation warnings in error-log causes system fa…
Browse files Browse the repository at this point in the history
…ilures because of changing the behavior in error reporting (#76)
  • Loading branch information
schengawegga committed Nov 1, 2023
1 parent d6c7a28 commit 0ae529d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
6 changes: 6 additions & 0 deletions Net/SMTP.php
Original file line number Diff line number Diff line change
Expand Up @@ -835,8 +835,10 @@ public function setAuthMethod($name, $callback, $prepend = true)
*/
protected function authDigestMD5($uid, $pwd, $authz = '')
{
/* TODO trigger deprecation error in 2.0.0 and remove authDigestMD5() in 3.0.0
trigger_error(__CLASS__ . ' (' . $this->host . '): Authentication method DIGEST-MD5' .
' is no longer secure and should be avoided.', E_USER_DEPRECATED);
*/

if (PEAR::isError($error = $this->put('AUTH', 'DIGEST-MD5'))) {
return $error;
Expand Down Expand Up @@ -890,8 +892,10 @@ protected function authDigestMD5($uid, $pwd, $authz = '')
*/
protected function authCRAMMD5($uid, $pwd, $authz = '')
{
/* TODO trigger deprecation error in 2.0.0 and remove authCRAMMD5() in 3.0.0
trigger_error(__CLASS__ . ' (' . $this->host . '): Authentication method CRAM-MD5' .
' is no longer secure and should be avoided.', E_USER_DEPRECATED);
*/

if (PEAR::isError($error = $this->put('AUTH', 'CRAM-MD5'))) {
return $error;
Expand Down Expand Up @@ -933,8 +937,10 @@ protected function authCRAMMD5($uid, $pwd, $authz = '')
*/
protected function authLogin($uid, $pwd, $authz = '')
{
/* TODO trigger deprecation error in 2.0.0 and remove authLogin() in 3.0.0
trigger_error(__CLASS__ . ' (' . $this->host . '): Authentication method LOGIN' .
' is no longer secure and should be avoided.', E_USER_DEPRECATED);
*/

if (PEAR::isError($error = $this->put('AUTH', 'LOGIN'))) {
return $error;
Expand Down
11 changes: 3 additions & 8 deletions package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@
<email>schengawegga@gmail.com</email>
<active>yes</active>
</lead>
<date>2023-10-26</date>
<date>2023-11-01</date>
<version>
<release>1.11.0</release>
<release>1.11.1</release>
<api>1.4.0</api>
</version>
<stability>
Expand All @@ -33,12 +33,7 @@
</stability>
<license uri="https://opensource.org/licenses/bsd-license.php">BSD-2-Clause</license>
<notes>
* Feature: Add SCRAM-SHA-1, SCRAM-SHA-224, SCRAM-SHA-256, SCRAM-SHA-384 and SCRAM-SHA-512 support (#76)
* Task: Mark authentication methods CRAM-MD5, DIGEST-MD5 and LOGIN as DEPRECATED with deprecation warnings in the error-log (#76)
* BugFix: SMTP: STARTTLS failed (code: 220, response: 2.0.0 Ready to start TLS) (#74)
* BugFix: Issue with non-blocking streams on establishing STARTTLS encryption (#74)
* BugFix: Implement TLS1.3 on STARTTLS encryption (#74)
* BugFix: using implode() instead of join() (#74)
* BugFix: Triggering deprecation warnings in error-log causes system failures because of changing the behavior in error reporting (#76)
</notes>
<contents>
<dir baseinstalldir="/" name="/">
Expand Down

0 comments on commit 0ae529d

Please sign in to comment.