oauth: add a generic method OAUTH to choose automatically a supported method #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EdouardVanbelle
commented
Dec 26, 2023
EdouardVanbelle
commented
- OAUTH pseudo method will elect either XOAUTH2 or OAUTHBEARER according to server's capabilities
EdouardVanbelle
force-pushed
the
feat/select-oauth-method
branch
from
096b9ad
to
d4e2e7e
Compare
|
@EdouardVanbelle: elect or select? |
This was referenced Dec 27, 2023
This was referenced Dec 27, 2023
alecpl
requested changes
Dec 27, 2023
Sieve.php
Outdated
| @@ -226,7 +226,8 @@ class Net_Sieve | |||
| * @param string $host Hostname of server. | |||
| * @param string $port Port of server. | |||
| * @param string $logintype Type of login to perform (see | |||
| * $supportedAuthMethods). | |||
| * $supportedAuthMethods), use `OAUTH` to elect | |||
| * the best method between XOAUTH2 & OAUTHBEARER. | |||
There was a problem hiding this comment.
If you put it this way, then I'd expect an explanation which one is "best".
Also, I'm not native, but "select" word might be better.
There was a problem hiding this comment.
rewording done
* OAUTH pseudo method will elect either XOAUTH2 or OAUTHBEARER according to server's capabilities Signed-off-by: Edouard Vanbelle <edouard@vanbelle.fr>
EdouardVanbelle
force-pushed
the
feat/select-oauth-method
branch
from
d4e2e7e
to
80ba726
Compare
EdouardVanbelle
changed the title
EdouardVanbelle
changed the title
|
@alecpl: Have you rights to add "Issues" section in this repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.