Fix platform list image dimensions #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
|
This looks good to me! |
|
Is this correct? For non-watchface apps, this shouldn't be a screenshot. |
|
@Katharine in that case do you think it should be platform dimensions for watchface, 144x144 for watchapp? that appears to work based on checking a few watchfaces and a few apps |
|
I think that would be correct, yes. |
crc-32
force-pushed
the
crc-32/cobble-patches
branch
from
590b53d to
5e94e2b
Compare
|
Will be live in prod imminently 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response is currently often a bad request as these images are screenshots and so match the platform dimensions.
I plan to use this for watchface locker images in cobble.