Initial port of concentricity project #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orviwan
approved these changes
Oct 17, 2016
| var round = require('./round'); | ||
| var rect = require('./rect'); | ||
|
|
||
| function DrawCommand(platform) { |
There was a problem hiding this comment.
Perhaps you could just require the relevant file based on platform.
if(rocky.watchInfo.platform === 'chalk') { //require round } else { //require rect }
There was a problem hiding this comment.
The require is a directive to webpack to include a module in the bundled JS file. At bundling time, rocky.watchInfo.platform doesn't exist (it's an API accessible at runtime) and I'm not sure how webpack would handle this (maybe ignore it?)
| this.minutes = round.drawMinutes; | ||
| this.seconds = round.drawSeconds; | ||
| } | ||
| if (['basalt', 'chalk', 'emery'].indexOf(platform) >= 0) { |
There was a problem hiding this comment.
again here, it would be simpler to:
if (platform === 'diorite') { //bw } else { //color }
There was a problem hiding this comment.
I wish we had a color/bw attribute on watchinfo =(
orviwan
reviewed
Nov 1, 2016
| // Set the drawing color | ||
| ctx.fillStyle = color; | ||
|
|
||
| if (endAngle == 0) { |
|
One minor comment, other than that LGTM! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An initial attempt to port the existing concentricity watchface over to Rocky.js